Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Random fixes #16

Merged
merged 7 commits into from
Jan 16, 2025
Merged

Random fixes #16

merged 7 commits into from
Jan 16, 2025

Conversation

mtfishman
Copy link
Member

@mtfishman mtfishman commented Jan 12, 2025

Random fixes for issues encountered while working on ITensor/ITensorBase.jl#4, ITensor/ITensors.jl#1611, ITensor/ITensorMPS.jl#108.

Copy link

codecov bot commented Jan 12, 2025

Codecov Report

Attention: Patch coverage is 24.59016% with 46 lines in your changes missing coverage. Please review.

Project coverage is 34.11%. Comparing base (4605dfc) to head (ffe7e86).
Report is 1 commits behind head on main.

Files with missing lines Patch % Lines
src/abstractnameddimsarray.jl 22.22% 35 Missing ⚠️
...aysBlockArraysExt/NamedDimsArraysBlockArraysExt.jl 0.00% 5 Missing ⚠️
src/abstractnamedinteger.jl 0.00% 3 Missing ⚠️
src/abstractnamedunitrange.jl 60.00% 2 Missing ⚠️
src/abstractnamedarray.jl 66.66% 1 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main      #16      +/-   ##
==========================================
- Coverage   35.62%   34.11%   -1.51%     
==========================================
  Files          14       14              
  Lines         612      636      +24     
==========================================
- Hits          218      217       -1     
- Misses        394      419      +25     
Flag Coverage Δ
docs 34.01% <24.59%> (-1.50%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@mtfishman mtfishman changed the title Random fixes [WIP] Random fixes Jan 12, 2025
@mtfishman mtfishman marked this pull request as draft January 12, 2025 00:50
@mtfishman mtfishman changed the title [WIP] Random fixes Random fixes Jan 16, 2025
@mtfishman mtfishman marked this pull request as ready for review January 16, 2025 23:27
@mtfishman mtfishman merged commit 555adcb into main Jan 16, 2025
10 checks passed
@mtfishman mtfishman deleted the fixes branch January 16, 2025 23:32
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant